Python3 dropped iteritems but items works exactly the same.

- This is a temporary solution until we have our own images

      Fixes: PROD-24956 (PROD:24956)

Change-Id: I4b81950abd5c31f95ab92c972192db0239069e72

The patch fixes typo which leads to not working
retry procedure in state.

Change-Id: I5f1863f0add3ace7cdee1c5e36a5a57e550ef893

- One Gemfile for all formulas tests
  - Update Makefile for OpenStack tests

Fixes: PROD-24408 (PROD:24408)
Change-Id: I747ffe1bfff4221244894173f16a3bda0aeaa9d5

* Those patch enable salt-(minion|master|api) services
    daemon auto-restart, in case any unclear exit will be
    detected. Systemd will try to run service each 3sec,
    till _StartLimitBurst_ limit will not be reached.
    (default 5)
  * Migrate systemd_minion_override.conf file
  * Duplicate patch for minion in base.sls and in service.sls

Change-Id: I65f35f1c50935af5692b740bb75ba0a629b18c48
Closes-Bug: PROD-23969 (PROD:23969)

- in inspec >= 3.0.0 there are changes in schema
	  which require to have tests/integration dir
	  to contain tests, otherwise fails
	- this is temporary workaround until we decide
	  proper fix

Change-Id: Ie64afebcb5ecbef41d04782d348704a96ea787a9

Change-Id: If5faaa420f07876d3d83296126aacd0309c5eaf3

Missing package dependancies added.

A missing "config" parameter for qemu-nbd based seeding
method added.

A new seeding method utilising Cloud-init added.
The qemu-nbd based method is still a default method
for backward compatibility.

To enable cloud-init, set the "seed" parameter on
a cluster or node level to "cloud-init".
To disable seeding, set this parameter to "false".
Setting this parameter to "true" will default to
the "qemu-nbd" method.

Salt Minion config file will be created automatically
and may be overrided via cluster or node level
metadata:

  salt:
    control:
      cluster:
        mycluster:
          seed: cloud-init
          cloud_init:
            user_data:
              salt_minion:
                conf:
                  master: 10.1.1.1

or for qemu-nbd case:

  salt:
    control:
      cluster:
        mycluster:
          seed: true
          config:
            host: 10.1.1.1

That may be useful when Salt Master has two IPs in
different networks and one of the networks isn't accessible
from a VM at the moment it's created. Setting a reachable
Salt master IP from metadata helps avoid potential problems.

Also, a liitle optimization has been done to parse/dump
an libvirt XML only once while modifying it.

Change-Id: I091cf409cb43ba2d0a18eaf2a08c11e88d0334e2
Closes-Bug: PROD-22191

Add TCP keepalive configuration options [1] to the list of accepted
minion config keys.

[1] https://docs.saltstack.com/en/latest/ref/configuration/minion.html

Change-Id: If80083fc793b86147b3691216dea571ea2cf0858
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>

Allow to enable VNC for provisioned VMs

Related PROD-23040 (PROD:23040)

Change-Id: I6cf2cb5ff66dcffb1532343a58416fb242703322

Change-Id: I88e88d9156d7bec0add9716d088e46dac6e3cf0b

libvirt xml: pass loader, virt machine, cpu mode

Spawning AArch64 VMs using salt.control.virt requires a few extra
domain configuration items to be configurable:
- libvirt xml: pass loader param to vm
  Based on upstream commit [1].
- libvirt xml: pass virt machine type
- libvirt xml: pass cpu mode to vm
- virt module: Allow NVRAM unlinking on DOM undefine
  UEFI-enabled VMs usually have pflash (NVRAM) devices attached,
  which require one additional libvirt flag to be passed at 'undefine'.
  This is usually the case for AArch64 (arm64) VMs, where AAVMF (AA64
  UEFI) is the only supported guest bootloader.

[1] https://github.com/saltstack/salt/commit/9cace9adb

Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>

This patchset obsoletes switching from "dhcp" to "static" during
deployment.

Example pillars:
salt:
  control:
    enabled: true
    virt_enabled: true
    size:
      small:
        cpu: 1
        ram: 1
    cluster:
      infra:
        domain: example.com
        engine: virt
        config:
          engine: salt
          host: master.domain.com
        cloud_init:
          network_data:
            links:
            - id: ens2
              name: ens2
              type: phy
          user_data:
            disable_ec2_metadata: true
            resize_rootfs: True
            timezone: UTC
            ssh_deletekeys: True
            ssh_genkeytypes: ['rsa', 'dsa', 'ecdsa']
            ssh_svcname: ssh
            locale: en_US.UTF-8
            disable_root: true
            apt_preserve_sources_list: false
            apt:
              sources_list: ""
              sources:
                ubuntu.list:
                  source: ${linux:system:repo:ubuntu:source}
                mcp_saltstack.list:
                  source: ${linux:system:repo:mcp_saltstack:source}
        node:
          ctl01:
            provider: kvm01.example.com
            image: ubuntu-16.04.qcow2
            size: small
            cloud_init:
              network_data:
                networks:
                - id: private-ipv4
                  ip_address: 192.168.0.161
                  link: ens2
                  netmask: 255.255.255.0
                  routes:
                  - gateway: 192.168.0.1
                    netmask: 0.0.0.0
                    network: 0.0.0.0
                  type: ipv4

Change-Id: I087518404c61e0bab2303e40957bacca94692102

Change-Id: I3ac728f84a0a63973ca7d90a679c096378eee7c8
Related-PROD: https://mirantis.jira.com/browse/PROD-20392

The metadata will be used to get list of enabled applications
that implement formula based upgrades.

Change-Id: Ibc368d993aa1c3c8715598513467da78792c752b

Related-Bug: PROD-21498 (PROD:21498)

Change-Id: I59ab700630f86f38d25571368a4cecb83baa988f

Change-Id: Ia9410364a82ac84889b80b30380ec5f897c7165c

Fixes: PROD-21792 (PROD:21792)

Change-Id: Iff22ba927c74a9cb3bd8726253106ebdbb20fe32

By default salt minion meta files are created with wide
permissions.

This makes OS tokens, keystone credentials unprotected.

Patch fixes this.

Prod-Related: CEEMCP-13 unprotected keystone credentials
Customer-Found

Change-Id: I18283cff4aec795e0656b7b3519381792e8a6e54

Change-Id: Iea79e2c8c9f29ddc5903a97c104e013878f63cd7

Salt (ca.sls) supports generation a few CA.cert but it works incorrectly.
When we generate a few ca.cert, salt must upload it to mine. But it overwrites previous ones.

Related-Prod: PROD-21740

Change-Id: I60f1089cc58758d3be65371deaaa69348fde86a4

This reverts commit a84007cf9e.

Change-Id: I547d741da0699abe3e645a0b767d55d5d53e0dbb

This reverts commit 0cd19b9ea1.

Change-Id: Iea9bc493c246d2c4fdee48d58883d21a10ebf054

The patch adds _orchestrate.conf file to salt minion
configuration. Its template searches for "/meta/salt.yml"
file across all installed formulas and parses them if found.
As of now config will contain following data, e.g.:
orchestration:
  deploy:
    applications:
      cinder:
        priority: 150
      keystone:
        priority: 100

Application priorities will be used later for salt deploy
orchestration

Change-Id: I56b0d15e5a13ca4975d98b9675991f84885120e6
Related-PROD: PROD-19973

There is issue [1] with reactor in salt 2017, one
of the workarounds is to set reactor workers to 1

[1] https://github.com/saltstack/salt/issues/47539

Change-Id: I47d76cc1dc5d0afe6d8b215e2d32cdbab3ac1a8c
Related-Prod: https://mirantis.jira.com/browse/PROD-21463

It is important to be able to increase timeouts on api when running
orchestrate tasks via pepper.

Change-Id: I3ff0988bfec3ec4715348c5de15247fe0b075443

The conflicting ID is 'libvirt_service' and is found in SLS:
- libvirt.server.service
- salt.control.virt

Change-Id: Ibb0b6f0a574a53f1cb8517a9fe0d7f0febb07bb3

Prod-Related: PROD-20747

Change-Id: Id7822963ab45ff7db3252f5329a9376aa4bf10d6

Change-Id: I602338811610d4ff08dfb8b2b3aed9dc46f5b3b0

The patch adds ability to configure REDIS as cache
backed for salt-master to be used as distibuted cache
further.

Change-Id: I62a29713c23ad3f591f6e937bfc5b13eba92f402
Related-PROD: PROD-20581

Change-Id: Idd52f0285ca3c858d21850f8d324cdfe64e149d6